feat(Store): dispatch one update action when multiple features are added or removed #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Aug 11, 2018
modules/store/src/reducer_manager.ts
Outdated
| this.dispatcher.next(<Action>{ | ||
| type: UPDATE, | ||
| feature, | ||
| feature: featureKeys[0], |
There was a problem hiding this comment.
There should be an array dispatched either way, with one more feature keys in the array.
There was a problem hiding this comment.
👍 got it, so always a features array. I'll update it tomorrow.
…ded or removed
BREAKING CHANGE:
BEFORE:
```ts
{type: '@ngrx/store/update-reducers', feature: 'feature1'}
{type: '@ngrx/store/update-reducers', feature: 'feature2'}
```
AFTER:
```ts
{type: '@ngrx/store/update-reducers', features: ['feature1',
'feature2']}
```
timdeschryver
force-pushed
the
pr/update-features
branch
from
04b8209
to
d2d9682
Compare
brandonroberts
approved these changes
Aug 16, 2018
|
Issue still there for Version 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1238
BREAKING CHANGE:
BEFORE:
When adding/removing one feature:
When adding/removing multiple features:
AFTER:
When adding/removing one feature:
When adding/removing multiple features: